netdev - Re: [PATCH net-next 2/2] net: phy: mxl-gpy: add MxL862xx support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e064f831-1fe9-42d2-96fc-d901c5be66a4@lunn.ch>
Date: Tue, 11 Nov 2025 02:32:38 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Xu Liang <lxu@...linear.com>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: mxl-gpy: add MxL862xx support

On Mon, Nov 10, 2025 at 10:35:00PM +0000, Daniel Golle wrote:
> Add PHY driver support for Maxlinear 86252 and 86282 switches.
> The PHYs built-into those switches are just like any other GPY 2.5G PHYs
> with the exception of the temperature sensor data being encoded in a
> different way.

Is there a temperature sensor per PHY, or just one for the whole
package?

Marvell did something similar for there SoHo switches. The temperature
sensor is mapped to each of internal PHYs register space, but in fact
there is a single sensor, not one per PHY.

> @@ -541,7 +581,7 @@ static int gpy_update_interface(struct phy_device *phydev)
>  	/* Interface mode is fixed for USXGMII and integrated PHY */
>  	if (phydev->interface == PHY_INTERFACE_MODE_USXGMII ||
>  	    phydev->interface == PHY_INTERFACE_MODE_INTERNAL)
> -		return -EINVAL;
> +		return 0;

This change is not obvious. There is no mention of it in the commit
message. Why has something which was an error become not an error?

    Andrew

---
pw-bot: cr