netdev - Re: [PATCH net-next v06 2/5] hinic3: Add PF management interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251110184743.72f0fe8d@kernel.org>
Date: Mon, 10 Nov 2025 18:47:43 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, <netdev@...r.kernel.org>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Markus Elfring <Markus.Elfring@....de>, Pavan
 Chebbi <pavan.chebbi@...adcom.com>, ALOK TIWARI <alok.a.tiwari@...cle.com>,
 <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>, luosifu
 <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>, Shen Chenyang
 <shenchenyang1@...ilicon.com>, Zhou Shuai <zhoushuai28@...wei.com>, Wu Like
 <wulike1@...wei.com>, Shi Jing <shijing34@...wei.com>, Luo Yang
 <luoyang82@...artners.com>, Meny Yossefi <meny.yossefi@...wei.com>, Gur
 Stavi <gur.stavi@...wei.com>
Subject: Re: [PATCH net-next v06 2/5] hinic3: Add PF management interfaces

On Sat, 8 Nov 2025 14:41:37 +0800 Fan Gong wrote:
> +	struct semaphore                port_state_sem;

You seem to init this semaphore to 1, could you not use a mutex?
Mutexes are faster and have better debugging. If you have a reason
for a semaphore please document.