netdev - Re: [PATCH net] net_sched: limit try_bulk_dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMkSBrbCxdai6Hn=aaeReqRpAcrZ4mA7J+t6dSEe8aM_dQ@mail.gmail.com>
Date: Wed, 12 Nov 2025 05:48:22 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: kuba@...nel.org
Cc: Eric Dumazet <edumazet@...gle.com>, davem@...emloft.net, pabeni@...hat.com, 
	horms@...nel.org, xiyou.wangcong@...il.com, jiri@...nulli.us, 
	kuniyu@...gle.com, willemb@...gle.com, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, hawk@...nel.org, patchwork-bot+netdevbpf@...nel.org, 
	toke@...hat.com
Subject: Re: [PATCH net] net_sched: limit try_bulk_dequeue_skb() batches

On Tue, Nov 11, 2025 at 9:10 PM <patchwork-bot+netdevbpf@...nel.org> wrote:
>
> Hello:
>
> This patch was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@...nel.org>:
>
> On Sun,  9 Nov 2025 16:12:15 +0000 you wrote:
> > After commit 100dfa74cad9 ("inet: dev_queue_xmit() llist adoption")
> > I started seeing many qdisc requeues on IDPF under high TX workload.
> >
> > $ tc -s qd sh dev eth1 handle 1: ; sleep 1; tc -s qd sh dev eth1 handle 1:
> > qdisc mq 1: root
> >  Sent 43534617319319 bytes 268186451819 pkt (dropped 0, overlimits 0 requeues 3532840114)
> >  backlog 1056Kb 6675p requeues 3532840114
> > qdisc mq 1: root
> >  Sent 43554665866695 bytes 268309964788 pkt (dropped 0, overlimits 0 requeues 3537737653)
> >  backlog 781164b 4822p requeues 3537737653
> >

Hrm. Should this have gone into net-next instead of net? Given that
the changes causing regression are still in net-next.
Dont think its a big deal if the merge is about to happen and i can
manually apply it since i was going to run some tests today.

cheers,
jamal

> > [...]
>
> Here is the summary with links:
>   - [net] net_sched: limit try_bulk_dequeue_skb() batches
>     https://git.kernel.org/netdev/net/c/0345552a653c
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>