netdev - Re: [PATCH net-next v4 02/14] net: skb: use dstref for storing dst entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRS_SEUbglrR_MeX@krikkit>
Date: Wed, 12 Nov 2025 18:09:28 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Marek Mietus <mmietus97@...oo.com>, edumazet@...gle.com,
	pabeni@...hat.com, kuba@...nel.org, davem@...emloft.net
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 02/14] net: skb: use dstref for storing dst
 entry

2025-11-12, 08:27:08 +0100, Marek Mietus wrote:
> Use the newly introduced dstref object for storing the dst entry
> in skb instead of using _skb_refdst, and remove code related
> to _skb_refdst.

This is an important change to a very core part of networking. You
need to CC all the networking maintainers/reviewers for this series
(ask scripts/get_maintainer.pl).

> This is mostly a cosmetic improvement. It improves readability

That rename, and the rest of the changes in this series. is causing
some non-negligible churn and will take a while to review, to ensure
all the conversions are correct.

@Maintainers can I get some time to look at this in detail?

Also, I'm not sure how we ended up from the previous proposal ("some
tunnels are under RCU so they don't need a reference" [1]) to this.

[1] https://lore.kernel.org/netdev/20250922110622.10368-1-mmietus97@yahoo.com/

-- 
Sabrina