netdev - Re: [PATCH net-next 07/11] can: mcp251xfd: add workaround for errata 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251112-gainful-sturdy-bird-296956-mkl@pengutronix.de>
Date: Wed, 12 Nov 2025 19:17:01 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-can@...r.kernel.org, 
	kernel@...gutronix.de, Gregor Herburger <gregor.herburger@...tq-group.com>, 
	Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>, Manivannan Sadhasivam <mani@...nel.org>
Subject: Re: [PATCH net-next 07/11] can: mcp251xfd: add workaround for errata
 5

On 12.11.2025 09:28:00, Jakub Kicinski wrote:
> On Wed, 12 Nov 2025 10:13:47 +0100 Marc Kleine-Budde wrote:
> > +static int
> > +mcp251xfd_regmap_nocrc_gather_write(void *context,
> > +				    const void *reg_p, size_t reg_len,
> > +				    const void *val, size_t val_len)
> > +{
> > +	const u16 byte_exclude = MCP251XFD_REG_IOCON +
> > +				 mcp251xfd_first_byte_set(MCP251XFD_REG_IOCON_GPIO_MASK);
>
> Looks like this is added by the next patch :(
>
> drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:48:59: error: ‘MCP251XFD_REG_IOCON_GPIO_MASK’ undeclared (first use in this function); did you mean ‘MCP251XFD_REG_IOCON_GPIO0’?
>    48 |                                  mcp251xfd_first_byte_set(MCP251XFD_REG_IOCON_GPIO_MASK);
>       |                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                                                           MCP251XFD_REG_IOCON_GPIO0
>
> Do you do rebases or do we have to take it as is?

I'll fix it and send a new PR.

Sorry for the noise,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)