netdev - Re: [PATCH net-next] net: dsa: remove definition of struct dsa_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f6f7b43-9153-4e56-a473-b9ad588f5014@gmail.com>
Date: Wed, 12 Nov 2025 22:17:13 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Simon Horman <horms@...nel.org>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: remove definition of struct
 dsa_switch_driver

On 11/12/2025 10:13 PM, Vladimir Oltean wrote:
> On Wed, Nov 12, 2025 at 09:46:24PM +0100, Heiner Kallweit wrote:
>> Since 93e86b3bc842 ("net: dsa: Remove legacy probing support")
>> this struct has no user any longer.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> ---
>>  include/net/dsa.h | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/include/net/dsa.h b/include/net/dsa.h
>> index 67762fdaf..d7845e83c 100644
>> --- a/include/net/dsa.h
>> +++ b/include/net/dsa.h
>> @@ -1312,11 +1312,6 @@ static inline int dsa_devlink_port_to_port(struct devlink_port *port)
>>  	return port->index;
>>  }
>>  
>> -struct dsa_switch_driver {
>> -	struct list_head	list;
>> -	const struct dsa_switch_ops *ops;
>> -};
>> -
>>  bool dsa_fdb_present_in_other_db(struct dsa_switch *ds, int port,
>>  				 const unsigned char *addr, u16 vid,
>>  				 struct dsa_db db);
>> -- 
>> 2.51.2
>>
> 
> Thanks. I think I also have this patch in some git tree on some computer
> somewhere...
> 
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> 
> Are you working on something, or did you just randomly notice it?

When working on following patch
https://patchwork.kernel.org/project/netdevbpf/patch/3abaa3c5-fbb9-4052-9346-6cb096a25878@gmail.com/
I came across 34b31da486a5 which refers to struct dsa_switch_driver in
its commmit message.