netdev - Re: [PATCH net-next] net: clear skb->sk in skb_release_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUBw5v4VD7Ekz78t4e8hcvWNbF-cF9RMCBY9WtW3oN6F2w@mail.gmail.com>
Date: Tue, 11 Nov 2025 21:54:59 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net: clear skb->sk in skb_release_head_state()

On Tue, Nov 11, 2025 at 7:12 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> skb_release_head_state() inlines skb_orphan().
>
> We need to clear skb->sk otherwise we can freeze TCP flows
> on a mostly idle host, because skb_fclone_busy() would
> return true as long as the packet is not yet processed by
> skb_defer_free_flush().
>
> Fixes: 1fcf572211da ("net: allow skb_release_head_state() to be called multiple times")
> Fixes: e20dfbad8aab ("net: fix napi_consume_skb() with alien skbs")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>