netdev - Re: [PATCH net-next v13 4/5] eea: create/destroy rx,tx queues for netdevice open and stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c6d84bf-fb2f-4096-8725-9c398e7a985e@redhat.com>
Date: Thu, 13 Nov 2025 12:35:26 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Wen Gu <guwen@...ux.alibaba.com>,
 Philo Lu <lulie@...ux.alibaba.com>, Lorenzo Bianconi <lorenzo@...nel.org>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Lukas Bulwahn <lukas.bulwahn@...hat.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Vivian Wang <wangruikang@...as.ac.cn>,
 Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
 Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v13 4/5] eea: create/destroy rx,tx queues for
 netdevice open and stop

On 11/10/25 12:46 PM, Xuan Zhuo wrote:
> +int eea_poll_tx(struct eea_net_tx *tx, int budget)
> +{
> +	struct eea_net *enet = tx->enet;
> +	u32 index = tx - enet->tx;
> +	struct netdev_queue *txq;
> +	u32 cleaned;
> +
> +	txq = netdev_get_tx_queue(enet->netdev, index);
> +
> +	__netif_tx_lock(txq, raw_smp_processor_id());

Why are you using the raw_ variant? This should be smp_processor_id(),
right?

/P