netdev - Re: [PATCH net-next v13 3/5] eea: probe the netdevice and create adminq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVY6y8iL0oiUOzh6C52+J4rRtwDFU-_cwXLdsWSdLFXQg@mail.gmail.com>
Date: Thu, 13 Nov 2025 13:31:06 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Wen Gu <guwen@...ux.alibaba.com>, 
	Philo Lu <lulie@...ux.alibaba.com>, Lorenzo Bianconi <lorenzo@...nel.org>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Lukas Bulwahn <lukas.bulwahn@...hat.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Vivian Wang <wangruikang@...as.ac.cn>, 
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>, Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v13 3/5] eea: probe the netdevice and create adminq

On Thu, 13 Nov 2025 at 12:38, Paolo Abeni <pabeni@...hat.com> wrote:
> On 11/10/25 12:46 PM, Xuan Zhuo wrote:
> > +static int eea_netdev_init_features(struct net_device *netdev,
> > +                                 struct eea_net *enet,
> > +                                 struct eea_device *edev)
> > +{
> > +     struct eea_aq_cfg *cfg;
> > +     int err;
> > +     u32 mtu;
> > +
> > +     cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
> > +     if (!cfg)
> > +             return -ENOMEM;
> > +
> > +     err = eea_adminq_query_cfg(enet, cfg);
> > +     if (err)
> > +             goto err_free;
> > +
> > +     mtu = le16_to_cpu(cfg->mtu);
> > +     if (mtu < ETH_MIN_MTU) {
> > +             dev_err(edev->dma_dev, "The device gave us an invalid MTU. Here we can only exit the initialization. %d < %d",
>
> Minor nit: missing trailing '\n'.

And please use %u for unsigned values.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds