netdev - Re: [PATCH net-next v4 09/14] net: wireguard: convert send{4,6} to use a noref dst when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRYKE2rKobILiqAG@zx2c4.com>
Date: Thu, 13 Nov 2025 17:40:51 +0100
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Marek Mietus <mmietus97@...oo.com>
Cc: netdev@...r.kernel.org, sd@...asysnail.net, kuba@...nel.org
Subject: Re: [PATCH net-next v4 09/14] net: wireguard: convert send{4,6} to
 use a noref dst when possible

Hi Marek,

On Wed, Nov 12, 2025 at 08:27:15AM +0100, Marek Mietus wrote:
> send{4,6} unnecessarily reference the dst_entry from the
> dst_cache when interacting with the cache.
> 
> Reduce this overhead by avoiding the redundant refcount increments.
> 
> This is only possible in flows where the cache is used. Otherwise, we
> fall-back to a referenced dst.
> 
> These changes are safe as both ipv4 and ip6 support noref xmit under RCU
> which is already the case for the wireguard send{4,6} functions.

Assuming the rest of the patchset is fine, this patch is okay with me,
with one very small nit. The commit subject should be
    wireguard: socket: convert send{4,6} to use a noref dst when possible
instead of "net: wireguard" etc.

Please CC me on future revisions of this if you do a v2, and I'll give
my reviewed-by.

Thanks,
Jason