netdev - Re: [PATCH net-next v4 14/15] quic: add frame encoder and decoder base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_eEHLbMQ3+OTWdg6_4a_bKFOkO-ZL0y661Vovo9uEFB1g@mail.gmail.com>
Date: Thu, 13 Nov 2025 16:26:46 -0500
From: Xin Long <lucien.xin@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: network dev <netdev@...r.kernel.org>, quic@...ts.linux.dev, davem@...emloft.net, 
	kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>, 
	Stefan Metzmacher <metze@...ba.org>, Moritz Buhl <mbuhl@...nbsd.org>, Tyler Fanelli <tfanelli@...hat.com>, 
	Pengtao He <hepengtao@...omi.com>, Thomas Dreibholz <dreibh@...ula.no>, linux-cifs@...r.kernel.org, 
	Steve French <smfrench@...il.com>, Namjae Jeon <linkinjeon@...nel.org>, 
	Paulo Alcantara <pc@...guebit.com>, Tom Talpey <tom@...pey.com>, kernel-tls-handshake@...ts.linux.dev, 
	Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, 
	Steve Dickson <steved@...hat.com>, Hannes Reinecke <hare@...e.de>, Alexander Aring <aahringo@...hat.com>, 
	David Howells <dhowells@...hat.com>, Matthieu Baerts <matttbe@...nel.org>, 
	John Ericson <mail@...nericson.me>, Cong Wang <xiyou.wangcong@...il.com>, 
	"D . Wythe" <alibuda@...ux.alibaba.com>, Jason Baron <jbaron@...mai.com>, 
	illiliti <illiliti@...tonmail.com>, Sabrina Dubroca <sd@...asysnail.net>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Daniel Stenberg <daniel@...x.se>, 
	Andy Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v4 14/15] quic: add frame encoder and decoder base

On Thu, Nov 6, 2025 at 12:22 PM Xin Long <lucien.xin@...il.com> wrote:
>
> On Tue, Nov 4, 2025 at 7:47 AM Paolo Abeni <pabeni@...hat.com> wrote:
> >
> > On 10/29/25 3:35 PM, Xin Long wrote:
> > > +static void quic_frame_free(struct quic_frame *frame)
> > > +{
> > > +     struct quic_frame_frag *frag, *next;
> > > +
> > > +     if (!frame->type && frame->skb) { /* RX path frame with skb. */
> >
> > Are RX path frame with !skb expected/possible? such frames will be
> > 'misinterpreted' as TX ones, specifically will do `kfree(frame->data)`
> > which in turn could be a bad thing.
> >
> Yes, when generating and delivering an event to userspace, it
> keeps the frame content into frame->data, instead of frame->skb.
>
> There's no need check !frame->type for RX path,  and I will change it to:
>
>         if (frame->skb) { /* For stream/crypto/dgram frames on RX. */
>                 kfree_skb(frame->skb);
>                 goto out;
>         }
>
> if skb is set, it will go kfree_skb(frame->skb), instead of kfree(frame->data).
> Because if frame->skb is set, it only needs to do kfree_skb(frame->skb).
>
Just realized that frame->skb shares a union with frame->flist, which is
used only on TX. So instead of removing the check !frame->type, I will
put a comment here:

        /* Handle RX stream/crypto/dgram frames. Use !frame->type to detect RX,
         * since frame->skb shares a union with frame->flist, used only on TX.
         */
        if (!frame->type && frame->skb) {

Thanks.