netdev - RE: [Intel-wired-lan] [PATCH iwl-next v10 07/10] idpf: remove vport pointer from queue sets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB898661799F6FAA57927D1A45E5CDA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 13 Nov 2025 07:07:43 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Hay, Joshua A" <joshua.a.hay@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v10 07/10] idpf: remove vport
 pointer from queue sets



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Joshua Hay
> Sent: Thursday, November 13, 2025 1:42 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next v10 07/10] idpf: remove
> vport pointer from queue sets
> 
> Replace vport pointer in queue sets struct with adapter backpointer
> and vport_id as those are the primary fields necessary for virtchnl
> communication. Otherwise, pass the vport pointer as a separate
> parameter where available. Also move xdp_txq_offset to queue vector
> resource struct since we no longer have the vport pointer.
> 
> Reviewed-by: Madhu Chittim <madhu.chittim@...el.com>
> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h        |  4 +-
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 41 +++++-----
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 78 ++++++++++--------
> -
>  .../net/ethernet/intel/idpf/idpf_virtchnl.h   |  7 +-
>  drivers/net/ethernet/intel/idpf/xdp.c         | 11 ++-
>  drivers/net/ethernet/intel/idpf/xsk.c         |  5 +-
>  6 files changed, 80 insertions(+), 66 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h
> b/drivers/net/ethernet/intel/idpf/idpf.h
> index a86791b0ca2c..9fafe294f5f5 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h
> @@ -305,6 +305,7 @@ struct idpf_fsteer_fltr {

...

>  /**
>   * idpf_prepare_cfg_txqs_msg - prepare message to configure selected
> Tx queues
> - * @vport: virtual port data structure
> + * @vport_id: ID of virtual port queues are associatd with
associatd -> associated

Otherwise looks good for me.
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

...

> --
> 2.39.2