netdev - Re: [PATCH net-next 3/8] ovpn: notify userspace on client float event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdf87820e364dda792a962486bef595cd6428354.camel@mandelbit.com>
Date: Fri, 14 Nov 2025 10:26:31 +0100
From: Ralf Lici <ralf@...delbit.com>
To: Jakub Kicinski <kuba@...nel.org>, Antonio Quartulli <antonio@...nvpn.net>
Cc: netdev@...r.kernel.org, Sabrina Dubroca <sd@...asysnail.net>, Eric
 Dumazet	 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/8] ovpn: notify userspace on client float
 event

On Thu, 2025-11-13 at 18:21 -0800, Jakub Kicinski wrote:
> On Tue, 11 Nov 2025 22:47:36 +0100 Antonio Quartulli wrote:
> > +	if (ss->ss_family == AF_INET) {
> > +		sa = (struct sockaddr_in *)ss;
> > +		if (nla_put_in_addr(msg, OVPN_A_PEER_REMOTE_IPV4,
> > +				    sa->sin_addr.s_addr) ||
> > +		    nla_put_net16(msg, OVPN_A_PEER_REMOTE_PORT, sa-
> > >sin_port))
> > +			goto err_cancel_msg;
> > +	} else if (ss->ss_family == AF_INET6) {
> > +		sa6 = (struct sockaddr_in6 *)ss;
> > +		if (nla_put_in6_addr(msg, OVPN_A_PEER_REMOTE_IPV6,
> > +				     &sa6->sin6_addr) ||
> > +		    nla_put_u32(msg,
> > OVPN_A_PEER_REMOTE_IPV6_SCOPE_ID,
> > +				sa6->sin6_scope_id) ||
> > +		    nla_put_net16(msg, OVPN_A_PEER_REMOTE_PORT,
> > sa6->sin6_port))
> > +			goto err_cancel_msg;
> > +	} else {
> 
> presumably on this branch ret should be set to something?

You're right, otherwise it would return -EMSGSIZE which is not what we
want here.

-- 
Ralf Lici
Mandelbit Srl