netdev - Re: [PATCH net-next 3/8] ovpn: notify userspace on client float event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251113182155.26d69123@kernel.org>
Date: Thu, 13 Nov 2025 18:21:55 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Antonio Quartulli <antonio@...nvpn.net>
Cc: netdev@...r.kernel.org, Sabrina Dubroca <sd@...asysnail.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Ralf Lici
 <ralf@...delbit.com>
Subject: Re: [PATCH net-next 3/8] ovpn: notify userspace on client float
 event

On Tue, 11 Nov 2025 22:47:36 +0100 Antonio Quartulli wrote:
> +	if (ss->ss_family == AF_INET) {
> +		sa = (struct sockaddr_in *)ss;
> +		if (nla_put_in_addr(msg, OVPN_A_PEER_REMOTE_IPV4,
> +				    sa->sin_addr.s_addr) ||
> +		    nla_put_net16(msg, OVPN_A_PEER_REMOTE_PORT, sa->sin_port))
> +			goto err_cancel_msg;
> +	} else if (ss->ss_family == AF_INET6) {
> +		sa6 = (struct sockaddr_in6 *)ss;
> +		if (nla_put_in6_addr(msg, OVPN_A_PEER_REMOTE_IPV6,
> +				     &sa6->sin6_addr) ||
> +		    nla_put_u32(msg, OVPN_A_PEER_REMOTE_IPV6_SCOPE_ID,
> +				sa6->sin6_scope_id) ||
> +		    nla_put_net16(msg, OVPN_A_PEER_REMOTE_PORT, sa6->sin6_port))
> +			goto err_cancel_msg;
> +	} else {

presumably on this branch ret should be set to something?

> +		goto err_cancel_msg;
> +	}