netdev - RE: [Intel-wired-lan] [PATCH iwl-next v10 03/10] idpf: move queue resources to idpf_q_vec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS4PPF7551E655260DB51D48D8A7553BF48E5CAA@DS4PPF7551E6552.namprd11.prod.outlook.com>
Date: Fri, 14 Nov 2025 05:56:17 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Hay, Joshua A" <joshua.a.hay@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v10 03/10] idpf: move queue
 resources to idpf_q_vec_rsrc structure



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Joshua Hay
> Sent: Thursday, November 13, 2025 1:42 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-next v10 03/10] idpf: move
> queue resources to idpf_q_vec_rsrc structure
> 
> From: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> 
> Move both TX and RX queue resources to the newly introduced
> idpf_q_vec_rsrc structure.
> 
Please augment the commit message with a brief Why and Tested: section (split/single queue, XDP on/off, PTP/Rx tstamp, coalesce, RSS reconfig), given the breadth of changes

Everything else is fine for me.
Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> Reviewed-by: Anton Nadezhdin <anton.nadezhdin@...el.com>
> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> ---
> v9: move iterator declaration changes to commit after this
> v8:
> - rebase on AF_XDP series
> - remove dev param from_rx_desc_rel and access through q_vector
> - introduce per queue rsc flag to avoid vport check
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h        |  69 +--
>  .../net/ethernet/intel/idpf/idpf_ethtool.c    |  77 ++--
>  drivers/net/ethernet/intel/idpf/idpf_lib.c    |  67 +--
>  drivers/net/ethernet/intel/idpf/idpf_ptp.c    |  17 +-
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c   | 397 ++++++++++-----
> ---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.h   |  21 +-
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 258 ++++++------
>  .../net/ethernet/intel/idpf/idpf_virtchnl.h   |  12 +-
>  drivers/net/ethernet/intel/idpf/xdp.c         |  37 +-
>  drivers/net/ethernet/intel/idpf/xdp.h         |   6 +-
>  drivers/net/ethernet/intel/idpf/xsk.c         |   7 +-
>  11 files changed, 534 insertions(+), 434 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h
> b/drivers/net/ethernet/intel/idpf/idpf.h
> index f32dc148cfc2..781e0c8dbc2f 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h
> @@ -297,6 +297,25 @@ struct idpf_fsteer_fltr {
>   * @noirq_v_idx: ID of the NOIRQ vector
>   * @noirq_dyn_ctl_ena: value to write to the above to enable it
>   * @noirq_dyn_ctl: register to enable/disable the vector for NOIRQ
> queues
> + * @txq_grps: array of TX queue groups
> + * @txq_desc_count: TX queue descriptor count
> + * @complq_desc_count: nompletion queue descriptor count
nompletion -> completion

> --
> 2.39.2