netdev - Re: [PATCH net-next v4 0/2] convert drivers to use ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251114182845.14290f8b@kernel.org>
Date: Fri, 14 Nov 2025 18:28:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Manish Chopra <manishc@...vell.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Richard
 Cochran <richardcochran@...il.com>, Simon Horman <horms@...nel.org>, Jacob
 Keller <jacob.e.keller@...el.com>, Kory Maincent
 <kory.maincent@...tlin.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 0/2] convert drivers to use ndo_hwtstamp
 callbacks part 4

On Thu, 13 Nov 2025 19:13:23 +0000 Vadim Fedorenko wrote:
> - restore netif_running() check in qede driver

bnx2x needs the same check, right? We're not deleting the ioctl code
but it used to check if the device is up.

As for the extack message:

+	if (!netif_running(netdev)) {
+		NL_SET_ERR_MSG_MOD(extack, "Device is not running");
+		return -EAGAIN;
+	}

it's probably more intuitive for the the user to say "Device is down".
-- 
pw-bot: cr