netdev - Re: [PATCH v20 04/22] cxl: Add type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92642b5f-6b74-43b4-994b-909f90bc4e79@amd.com>
Date: Sat, 15 Nov 2025 08:11:02 +0000
From: Alejandro Lucero Palau <alucerop@....com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>,
 alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 dave.jiang@...el.com, Alison Schofield <alison.schofield@...el.com>,
 Ben Cheatham <benjamin.cheatham@....com>
Subject: Re: [PATCH v20 04/22] cxl: Add type2 device basic support


On 11/12/25 15:33, Jonathan Cameron wrote:
> On Mon, 10 Nov 2025 15:36:39 +0000
> alejandro.lucero-palau@....com wrote:
>
>> From: Alejandro Lucero <alucerop@....com>
>>
>> Differentiate CXL memory expanders (type 3) from CXL device accelerators
>> (type 2) with a new function for initializing cxl_dev_state and a macro
>> for helping accel drivers to embed cxl_dev_state inside a private
>> struct.
>>
>> Move structs to include/cxl as the size of the accel driver private
>> struct embedding cxl_dev_state needs to know the size of this struct.
>>
>> Use same new initialization with the type3 pci driver.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
>> Reviewed-by: Ben Cheatham <benjamin.cheatham@....com>
> One minor thing that's probably a merge conflict gone slightly wrong
> or something like that. After this patch you end up with two
> CXL_NR_PARTITIONS_MAX defines.


Good catch!


I'll fix it.


Thanks


>
>> ---
>>   drivers/cxl/core/mbox.c      |  12 +-
>>   drivers/cxl/core/memdev.c    |  32 +++++
>>   drivers/cxl/core/pci_drv.c   |  15 +--
>>   drivers/cxl/cxl.h            |  97 +--------------
>>   drivers/cxl/cxlmem.h         |  85 +------------
>>   include/cxl/cxl.h            | 226 +++++++++++++++++++++++++++++++++++
>>   tools/testing/cxl/test/mem.c |   3 +-
>>   7 files changed, 276 insertions(+), 194 deletions(-)
>>   create mode 100644 include/cxl/cxl.h
>>
>> diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h
>> new file mode 100644
>> index 000000000000..13d448686189
>> --- /dev/null
>> +++ b/include/cxl/cxl.h
>> @@ -0,0 +1,226 @@
>
>
>> +#define CXL_NR_PARTITIONS_MAX 2
> Adds a definition but doesn't remove the one in driver/cxl/cxlmem.h
> That seems odd.
>
>
>