netdev - Re: [PATCH] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <234545199.8734622.1763313511799@mail.yahoo.com>
Date: Sun, 16 Nov 2025 17:18:31 +0000 (UTC)
From: Mietek N <namiltd@...oo.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "linus.walleij@...aro.org" <linus.walleij@...aro.org>, 
	"edumazet@...gle.com" <edumazet@...gle.com>, 
	"alsi@...g-olufsen.dk" <alsi@...g-olufsen.dk>, 
	"olteanv@...il.com" <olteanv@...il.com>, 
	"kuba@...nel.org" <kuba@...nel.org>, 
	"pabeni@...hat.com" <pabeni@...hat.com>, 
	Andrew Lunn <andrew@...n.ch>, 
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH] net: dsa: realtek: rtl8365mb: fix return value in
 rtl8365mb_phy_ocp_write

Function rtl8365mb_phy_ocp_write() always returns 0, even when an erroroccurs during register access. This patch fixes the return value to
propagate the actual error code from regmap operations.

Fixes: 964a56e ("net: dsa: realtek: add RTL8365MB switch driver")
Signed-off-by: Mieczyslaw Nalewaj <namiltd@...oo.com>
---
drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index 964a56e..d06b384 100644

--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -769,7 +769,7 @@ static int rtl8365mb_phy_ocp_write(struct realtek_priv *priv, int phy,
 out:
    rtl83xx_unlock(priv);
 
-    return 0;
+    return ret;
 }
 
 static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum)
--
2.43.0