netdev - Re: [PATCH v20 06/22] cxl: Move pci generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ef9ee39-b568-4f08-ba4f-82be65248cf6@intel.com>
Date: Mon, 17 Nov 2025 08:00:26 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Alejandro Lucero Palau <alucerop@....com>,
 Jonathan Cameron <jonathan.cameron@...wei.com>,
 alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 Ben Cheatham <benjamin.cheatham@....com>, Fan Ni <fan.ni@...sung.com>,
 Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v20 06/22] cxl: Move pci generic code



On 11/15/25 1:12 AM, Alejandro Lucero Palau wrote:
> 
> On 11/12/25 15:41, Jonathan Cameron wrote:
>> On Mon, 10 Nov 2025 15:36:41 +0000
>> alejandro.lucero-palau@....com wrote:
>>
>>> From: Alejandro Lucero <alucerop@....com>
>>>
>>> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
>>> meanwhile cxl/pci.c implements the functionality for a Type3 device
>>> initialization.
>>>
>>> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
>>> exported and shared with CXL Type2 device initialization.
>>>
>>> Fix cxl mock tests affected by the code move, deleting a function which
>>> indeed was not being used since commit 733b57f262b0("cxl/pci: Early
>>> setup RCH dport component registers from RCRB").
>> As I replied late to v19, I'd like to understand more about this comment.
>> If it was not being used, why can't we remove it before this patch?
> 
> 
> I replied back then, but if you think this is what I should do with no exception, I'll do it.
> 
> Should it be part of this patchset or something I should send independently?

Alison is out this week due to a personal matter. I would just send this ahead and be done with it if it's just a function removal cleanup. 

DJ

> 
> 
>>
>>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>> Reviewed-by: Ben Cheatham <benjamin.cheatham@....com>
>>> Reviewed-by: Fan Ni <fan.ni@...sung.com>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
>>> Reviewed-by: Dan Williams <dan.j.williams@...el.com>