netdev - Re: [PATCH net v3] xsk: avoid data corruption on cq descriptor number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251117155919.1834be7b@kernel.org>
Date: Mon, 17 Nov 2025 15:59:19 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Fernando Fernandez Mancera <fmancera@...e.de>
Cc: Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 netdev@...r.kernel.org, csmate@....hu, kerneljasonxing@...il.com,
 bjorn@...nel.org, sdf@...ichev.me, jonathan.lemon@...il.com,
 bpf@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH net v3] xsk: avoid data corruption on cq descriptor
 number

On Mon, 17 Nov 2025 17:11:48 +0100 Fernando Fernandez Mancera wrote:
> >> Instead use the skb destructor_arg pointer along with pointer tagging.
> >> As pointers are always aligned to 8B, use the bottom bit to indicate
> >> whether this a single address or an allocated struct containing several
> >> addresses.
> >>
> >> Fixes: 30f241fcf52a ("xsk: Fix immature cq descriptor production")
> >> Closes: https://lore.kernel.org/netdev/0435b904-f44f-48f8-afb0-68868474bf1c@nop.hu/
> >> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> >> Signed-off-by: Fernando Fernandez Mancera <fmancera@...e.de>  
> > 
> > Tested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> > Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> > 
> > Fernando thanks for stepping in and providing this fix!
> > And thanks Jakub for ptr tagging trick.
> > 
> > @BPF maintainers, please apply this patch.

This is just an skb patch, let's stick to net as previously requested 
if that's okay with everyone.

> Thank you, please note that if rebasing is needed I can send a rebased 
> version. Just let me know.

I think repost would be good. Get a fresh run thru CIs and re-raise it
to reviewers who may have started ignoring the thread.