netdev - RE: [PATCH net-next] devlink: Notify eswitch mode changes to devlink monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY8PR12MB719576A592BCF41591F83C23DCD6A@CY8PR12MB7195.namprd12.prod.outlook.com>
Date: Tue, 18 Nov 2025 05:25:23 +0000
From: Parav Pandit <parav@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "horms@...nel.org"
	<horms@...nel.org>, Jiri Pirko <jiri@...dia.com>
Subject: RE: [PATCH net-next] devlink: Notify eswitch mode changes to devlink
 monitor



> From: Jakub Kicinski <kuba@...nel.org>
> Sent: 18 November 2025 09:11 AM
> 
> On Sat, 15 Nov 2025 04:51:25 +0200 Parav Pandit wrote:
> > +	err = devlink_nl_eswitch_fill(msg, devlink,
> DEVLINK_CMD_ESWITCH_SET,
> 
> I've never seen action command ID being used for a notification.
> Either use an existing type which has the same message format, or if no
> message which naturally fits exists allocate a new ID.

I am not sure fully.
1. devlink_notify() uses DEVLINK_CMD_NEW.

2. devlink_port_notify() uses DEVLINK_CMD_PORT_NEW which is the input cmd on port creation supplied by the user space.

3. devlink_params_notify_register() uses DEVLINK_CMD_PARAM_NEW.

Do you mean #1 and #3 are not user-initiated commands, hence such an action command ID is ok vs #2 is not ok?
I probably misunderstanding your comment.