netdev - Re: [PATCH v3 net-next 3/3] net: use napi_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoA8Ve2zy7UDLsksdsKP1cQokWQD1h41UBjPoXWqQ-DU7A@mail.gmail.com>
Date: Tue, 18 Nov 2025 17:22:36 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Subject: Re: [PATCH v3 net-next 3/3] net: use napi_skb_cache even in process context

On Tue, Nov 18, 2025 at 4:32 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Mon, Nov 17, 2025 at 6:07 PM Jason Xing <kerneljasonxing@...il.com> wrote:
> >
> > On Mon, Nov 17, 2025 at 10:31 PM Jason Xing <kerneljasonxing@...il.com> wrote:
> > >
> > > On Mon, Nov 17, 2025 at 5:48 PM Eric Dumazet <edumazet@...gle.com> wrote:
> > > >
>
> > >
> > > >
> > > > We can add a static key to enable/disable the behaviors that are most
> > > > suited to a particular workload.
> > >
> > > Are we going to introduce a new knob to control this snippet in
> > > napi_consume_skb()?
> >
> > That's it. For single flow in xsk scenarios, adding something like a
> > static key to avoid 1) using napi_skb_cache_get() in this patch, 2)
> > deferring free in commit [3] can contribute to a higher performance
> > back to more than 1,900,000 pps. I have no clue if adding a new sysctl
> > is acceptable.
>
> I will add one as soon as this series is merged.

Great! Thanks!