netdev - Re: [PATCH bpf-next v1 1/1] bpf: Annotate rqspinlock lock acquiring functions with __must

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251118104247.0bf0b17d@pumpkin>
Date: Tue, 18 Nov 2025 10:42:47 +0000
From: David Laight <david.laight.linux@...il.com>
To: Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc: Amery Hung <ameryhung@...il.com>, bpf@...r.kernel.org,
 netdev@...r.kernel.org, alexei.starovoitov@...il.com, andrii@...nel.org,
 daniel@...earbox.net, kernel-team@...a.com
Subject: Re: [PATCH bpf-next v1 1/1] bpf: Annotate rqspinlock lock acquiring
 functions with __must_check

On Tue, 18 Nov 2025 05:16:50 -0500
Kumar Kartikeya Dwivedi <memxor@...il.com> wrote:

> On Mon, 17 Nov 2025 at 14:15, Amery Hung <ameryhung@...il.com> wrote:
> >
> > Locking a resilient queued spinlock can fail when deadlock or timeout
> > happen. Mark the lock acquring functions with __must_check to make sure
> > callers always handle the returned error.
> >
> > Suggested-by: Andrii Nakryiko <andrii@...nel.org>
> > Signed-off-by: Amery Hung <ameryhung@...il.com>
> > ---  
> 
> Looks like it's working :)
> I would just explicitly ignore with (void) cast the locktorture case.

I'm not sure that works - I usually have to try a lot harder to ignore
a '__must_check' result.

	David