netdev - Re: [PATCH] net: dsa: realtek: rtl8365mb: Do not subtract ifOutDiscards from rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a31ffe45-5457-42a2-aac5-2f2da9368408@lunn.ch>
Date: Tue, 18 Nov 2025 17:40:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Mieczyslaw Nalewaj <namiltd@...oo.com>
Cc: Netdev <netdev@...r.kernel.org>,
	"inus.walleij@...aro.org" <inus.walleij@...aro.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"alsi@...g-olufsen.dk" <alsi@...g-olufsen.dk>,
	"olteanv@...il.com" <olteanv@...il.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH] net: dsa: realtek: rtl8365mb: Do not subtract
 ifOutDiscards from rx_packets

On Mon, Nov 17, 2025 at 11:58:48PM +0000, Mieczyslaw Nalewaj wrote:
> rx_packets should report the number of frames successfully received:
> unicast + multicast + broadcast. Subtracting ifOutDiscards (a TX
> counter) is incorrect and can undercount RX packets. RX drops are
> already reported via rx_dropped (e.g. etherStatsDropEvents), so
> there is no need to adjust rx_packets.
> 
> This patch removes the subtraction of ifOutDiscards from rx_packets
> in rtl8365mb_stats_update().

It does look like a cut/paste error of some sort.

Please could you figure out a Fixes: tag, and submit this to net.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

    Andrew

---
pw-bot: cr