netdev - Re: [PATCH net-next v4 02/14] net: skb: use dstref for storing dst entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251117161045.10c9c7bd@kernel.org>
Date: Mon, 17 Nov 2025 16:10:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Marek Mietus <mmietus97@...oo.com>
Cc: Sabrina Dubroca <sd@...asysnail.net>, Eric Dumazet
 <edumazet@...gle.com>, netdev@...r.kernel.org, pabeni@...hat.com,
 davem@...emloft.net
Subject: Re: [PATCH net-next v4 02/14] net: skb: use dstref for storing dst
 entry

On Mon, 17 Nov 2025 12:31:00 +0100 Marek Mietus wrote:
> > But IMO Jakub's comment about technical debt is not addressed by
> > pushing dstref all over the tunnel code.
> 
> I understood it differently. I thought the aforementioned debt referred
> to maintaining two different APIs that accomplish the same result, which
> is why I took the time to replace all callers in all of the tunnels to use
> the new API, and removed the old API. Maybe Jakub can clarify.

True, my direct complaint was about only converting a subset of tunnels.
But as Eric said you seem to have gone too far in the opposite direction
now :(