netdev - Re: [PATCH v3 net-next 3/3] net: use napi_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUAH0P4Ma+55DUJZCoJuaUiYBoP4bSkHUjKwKoVBo5p5Wg@mail.gmail.com>
Date: Mon, 17 Nov 2025 20:03:29 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Jason Xing <kerneljasonxing@...il.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 3/3] net: use napi_skb_cache even in process context

On Sun, Nov 16, 2025 at 12:27 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> This is a followup of commit e20dfbad8aab ("net: fix napi_consume_skb()
> with alien skbs").
>
> Now the per-cpu napi_skb_cache is populated from TX completion path,
> we can make use of this cache, especially for cpus not used
> from a driver NAPI poll (primary user of napi_cache).
>
> We can use the napi_skb_cache only if current context is not from hard irq.
>
> With this patch, I consistently reach 130 Mpps on my UDP tx stress test
> and reduce SLUB spinlock contention to smaller values.
>
> Note there is still some SLUB contention for skb->head allocations.
>
> I had to tune /sys/kernel/slab/skbuff_small_head/cpu_partial
> and /sys/kernel/slab/skbuff_small_head/min_partial depending
> on the platform taxonomy.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>