netdev - Re: [PATCH net-next v14 4/5] eea: create/destroy rx,tx queues for netdevice open and stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251117201820.0acd0c5a@kernel.org>
Date: Mon, 17 Nov 2025 20:18:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Wen Gu <guwen@...ux.alibaba.com>, Philo Lu
 <lulie@...ux.alibaba.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Vadim
 Fedorenko <vadim.fedorenko@...ux.dev>, Dong Yibo <dong100@...se.com>, Lukas
 Bulwahn <lukas.bulwahn@...hat.com>, Geert Uytterhoeven
 <geert+renesas@...der.be>, Vivian Wang <wangruikang@...as.ac.cn>, MD Danish
 Anwar <danishanwar@...com>, Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v14 4/5] eea: create/destroy rx,tx queues for
 netdevice open and stop

On Fri, 14 Nov 2025 14:15:05 +0800 Xuan Zhuo wrote:
> +static int eea_netdev_open(struct net_device *netdev)
> +{
> +	struct eea_net *enet = netdev_priv(netdev);
> +	struct eea_net_init_ctx ctx;
> +	int err;
> +
> +	if (enet->link_err) {
> +		netdev_err(netdev, "netdev open err, because link error: %d\n",
> +			   enet->link_err);
> +		return -EBUSY;
> +	}
> +
> +	enet_init_ctx(enet, &ctx);
> +
> +	err = eea_alloc_rxtx_q_mem(&ctx);
> +	if (err)
> +		return err;
> +
> +	enet_bind_new_q_and_cfg(enet, &ctx);
> +
> +	err = eea_active_ring_and_irq(enet);
> +	if (err)
> +		return err;
> +
> +	return eea_start_rxtx(netdev);

Looks like this is missing teardown in case eea_start_rxtx() failed
-- 
pw-bot: cr