netdev - Re: [PATCH nf-next v9 2/3] net: netfilter: Add IPIP flowtable tx sw acceleration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR0Lj3ph0RYtpleX@calendula>
Date: Wed, 19 Nov 2025 01:13:23 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	Shuah Khan <shuah@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	Phil Sutter <phil@....cc>, Florian Westphal <fw@...len.de>,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH nf-next v9 2/3] net: netfilter: Add IPIP flowtable tx sw
 acceleration

Hi Lorenzo,

I found one more issue: caching the ip6 daddr does not work because
skb_cow_head() can reallocate the skb header, invalidating all
pointers.

I went back to use the other_tuple, it is safer, new branch:

        flowtable-consolidate-xmit+ipip3

Hopefully, this is the last iteration for this series.

I am attaching a diff that compares flowtable-consolidate-xmit+ipip2
vs. flowtable-consolidate-xmit+ipip3 branches.

I also made a few cosmetic edits.

View attachment "diff-v2-v3.patch" of type "text/x-diff" (3100 bytes)