netdev - Re: [External] : [PATCH net-next v15 1/5] eea: introduce PCI framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ff95a71-69e5-4cb6-9b2a-5224c983bdc2@oracle.com>
Date: Wed, 19 Nov 2025 14:00:42 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Wen Gu <guwen@...ux.alibaba.com>,
        Philo Lu <lulie@...ux.alibaba.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        Dong Yibo <dong100@...se.com>,
        Lukas Bulwahn <lukas.bulwahn@...hat.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Vivian Wang <wangruikang@...as.ac.cn>,
        MD Danish Anwar <danishanwar@...com>,
        Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [External] : [PATCH net-next v15 1/5] eea: introduce PCI
 framework

> +
> +static int eea_pci_setup(struct pci_dev *pci_dev, struct eea_pci_device *ep_dev)
> +{
> +	int err, n;
> +
> +	ep_dev->pci_dev = pci_dev;
> +
> +	err = pci_enable_device(pci_dev);
> +	if (err)
> +		return err;
> +
> +	err = pci_request_regions(pci_dev, "EEA");
> +	if (err)
> +		goto err_disable_dev;
> +
> +	pci_set_master(pci_dev);
> +
> +	err = dma_set_mask_and_coherent(&pci_dev->dev, DMA_BIT_MASK(64));
> +	if (err) {
> +		dev_warn(&pci_dev->dev, "Failed to enable 64-bit DMA.\n");
> +		goto err_release_regions;
> +	}
> +
> +	ep_dev->reg = pci_iomap(pci_dev, 0, 0);
> +	if (!ep_dev->reg) {
> +		dev_err(&pci_dev->dev, "Failed to map pci bar!\n");
> +		err = -ENOMEM;
> +		goto err_release_regions;
> +	}
> +
> +	ep_dev->edev.rx_num = cfg_read32(ep_dev->reg, rx_num_max);
> +	ep_dev->edev.tx_num = cfg_read32(ep_dev->reg, tx_num_max);
> +
> +	/* 2: adminq, error handle*/
> +	n = ep_dev->edev.rx_num + ep_dev->edev.tx_num + 2;
> +	err = pci_alloc_irq_vectors(ep_dev->pci_dev, n, n, PCI_IRQ_MSIX);
> +	if (err < 0)
> +		goto err_unmap_reg;
> +
> +	ep_dev->msix_vec_n = n;

msix_vec_n = err; as n is not granted

  or
drivers/vdpa/alibaba/eni_vdpa.c#n167
like this -> if (ret != vectors)
although I am not fully convinced it is ideal.

> +
> +	ep_dev->db_base = ep_dev->reg + EEA_PCI_DB_OFFSET;
> +	ep_dev->edev.db_blk_size = cfg_read32(ep_dev->reg, db_blk_size);
> +
> +	return 0;
> +
> +err_unmap_reg:
> +	pci_iounmap(pci_dev, ep_dev->reg);
> +	ep_dev->reg = NULL;
> +
> +err_release_regions:
> +	pci_release_regions(pci_dev);
> +
> +err_disable_dev:
> +	pci_disable_device(pci_dev);
> +
> +	return err;
> +}
> +
> +void __iomem *eea_pci_db_addr(struct eea_device *edev, u32 off)
> +{
> +	return edev->ep_dev->db_base + off;
> +}
> +
> +u64 eea_pci_device_ts(struct eea_device *edev)
> +{
> +	struct eea_pci_device *ep_dev = edev->ep_dev;
> +
> +	return cfg_readq(ep_dev->reg, hw_ts);
> +}
> +
> +static int eea_init_device(struct eea_device *edev)
> +{
> +	int err;
> +
> +	err = eea_device_reset(edev);
> +	if (err)
> +		return err;
> +
> +	eea_pci_io_set_status(edev, BIT(0) | BIT(1));
> +
> +	err = eea_negotiate(edev);
> +	if (err)
> +		goto err;
> +
> +	/* do net device probe ... */
> +
> +	return 0;
> +err:
> +	eea_add_status(edev, EEA_S_FAILED);
> +	return err;
> +}
> +
> +static int __eea_pci_probe(struct pci_dev *pci_dev,
> +			   struct eea_pci_device *ep_dev)
> +{
> +	int err;
> +
> +	pci_set_drvdata(pci_dev, ep_dev);
> +
> +	err = eea_pci_setup(pci_dev, ep_dev);
> +	if (err)
> +		return err;
> +
> +	err = eea_init_device(&ep_dev->edev);
> +	if (err)
> +		goto err_pci_rel;
> +
> +	return 0;
> +
> +err_pci_rel:
> +	eea_pci_release_resource(ep_dev);
> +	return err;
> +}
> +
> +static void __eea_pci_remove(struct pci_dev *pci_dev, bool flush_ha_work)

what is use of flush_ha_work

> +{
> +	struct eea_pci_device *ep_dev = pci_get_drvdata(pci_dev);
> +	struct device *dev = get_device(&ep_dev->pci_dev->dev);
> +
> +	pci_disable_sriov(pci_dev);
> +
> +	eea_pci_release_resource(ep_dev);
> +
> +	put_device(dev);
> +}
> +
Thanks,
Alok