netdev - Re: [PATCH net-next v2 09/12] selftests: drv-net: add a Python version of the GRO test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871pluc8ro.fsf@nvidia.com>
Date: Wed, 19 Nov 2025 16:54:45 +0100
From: Petr Machata <petrm@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
	<willemdebruijn.kernel@...il.com>, <shuah@...nel.org>, <sdf@...ichev.me>,
	<krakauer@...gle.com>, <linux-kselftest@...r.kernel.org>, <petrm@...dia.com>,
	<matttbe@...nel.org>
Subject: Re: [PATCH net-next v2 09/12] selftests: drv-net: add a Python
 version of the GRO test


Jakub Kicinski <kuba@...nel.org> writes:

> Rewrite the existing gro.sh test in Python. The conversion
> not exact, the changes are related to integrating the test
> with our "remote endpoint" paradigm. The test now reads
> the IP addresses from the user config. It resolves the MAC
> address (including running over Layer 3 networks).
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Petr Machata <petrm@...dia.com>

However:

> +    base_cmd_args = [
> +        f"--{protocol}",
> +        f"--dmac {_resolve_dmac(cfg, ipver)}",
> +        f"--smac {cfg.remote_dev['address']}",
> +        f"--daddr {cfg.addr_v[ipver]}",
> +        f"--saddr {cfg.remote_addr_v[ipver]}",
> +        f"--test {test_name}",
> +        "--verbose"
> +    ]
> +    base_args = " ".join(base_cmd_args)
> +

> +    max_retries = 6
> +    for attempt in range(max_retries):

The original had a comment about flakiness which was IMHO useful. The
"retry failures" paradigm on its own is transparent enough, but the
comment explained why the flakiness comes up.

2c