netdev - Re: [PATCH net-next] amd-xgbe: let the MAC manage PHY PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ca796b8-2add-4101-a3d5-cd7135662938@bootlin.com>
Date: Wed, 19 Nov 2025 16:57:47 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Raju Rangoju <Raju.Rangoju@....com>, netdev@...r.kernel.org
Cc: pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, andrew+netdev@...n.ch, Shyam-sundar.S-k@....com
Subject: Re: [PATCH net-next] amd-xgbe: let the MAC manage PHY PM

Hi Raju,

On 19/11/2025 10:31, Raju Rangoju wrote:
> Use the MAC managed PM flag to indicate that MAC driver takes care of
> suspending/resuming the PHY, and reset it when the device is brought up.
> 
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c    | 3 +++
>  drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index f3adf29b222b..1c03fb138ce6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -1266,6 +1266,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata)
>  
>  	clear_bit(XGBE_STOPPED, &pdata->dev_state);
>  
> +	/* Reset the phy settings */
> +	xgbe_phy_reset(pdata);
> +

At a first glance, this looks like 2 different things, so maybe 2
different patches ?

That said, with this change does it still make sense to call
xgbe_phy_reset() in xgbe_open() ?

With this patch we have :

xgpe_open() {

  xgbe_phy_reset();

  xgbe_start() {
    xgbe_phy_reset(); /* again */
  }
}

Can you remove the first call in .ndo_open ?

Maxime