netdev - Re: [PATCH v3 1/1] ynl: samples: add tc filter example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118183743.48be61e0@kernel.org>
Date: Tue, 18 Nov 2025 18:37:43 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Zahari Doychev <zahari.doychev@...ux.com>
Cc: donald.hunter@...il.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, jacob.e.keller@...el.com,
 ast@...erby.net, matttbe@...nel.org, netdev@...r.kernel.org,
 jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 johannes@...solutions.net
Subject: Re: [PATCH v3 1/1] ynl: samples: add tc filter example

On Mon, 17 Nov 2025 11:57:08 +0100 Zahari Doychev wrote:
> +	if (tc_clsact_add(ys, ifi))
> +		goto err_destroy;
> +
> +	tc_filter_config(ys, ifi);
> +
> +	tc_clsact_del(ys, ifi);
> +
> +err_destroy:
> +	ynl_sock_destroy(ys);
> +	return 2;

Let's return 0 if nothing failed? Maybe:

	if (tc_clsact_add(ys, ifi)) {
		ret = 2;
		goto err_destroy;
	}

	ret = 0;
	if (tc_filter_config(ys, ifi))
		ret = 3;

	if (tc_clsact_del(ys, ifi))
		ret = 4;

err_destroy:
	ynl_sock_destroy(ys);
	return ret;
}
-- 
pw-bot: cr