netdev - Re: [PATCH net-next v11 06/12] virtio_net: Create a FF group for ethtool steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a81f3384-2a64-4ebd-b563-76d2d5237df3@nvidia.com>
Date: Wed, 19 Nov 2025 11:14:54 -0600
From: Dan Jurgens <danielj@...dia.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: netdev@...r.kernel.org, jasowang@...hat.com, pabeni@...hat.com,
 virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 jgg@...pe.ca, kevin.tian@...el.com, kuba@...nel.org, andrew+netdev@...n.ch,
 edumazet@...gle.com
Subject: Re: [PATCH net-next v11 06/12] virtio_net: Create a FF group for
 ethtool steering

On 11/19/25 3:36 AM, Michael S. Tsirkin wrote:
> On Tue, Nov 18, 2025 at 08:38:56AM -0600, Daniel Jurgens wrote:
>> +
>>  	ff->vdev = vdev;
>>  	ff->ff_supported = true;
>>  
> 
> So this is set here and never cleared.
> 
> But we never recreate the group on restore (after suspend).
> 
> sounds like we need virtnet_ff_cleanup/virtnet_ff_init on the
> suspend/restore path?

Yes, you're right.