netdev - Re: [PATCH net-next v11 04/12] virtio: Expose object create and destroy API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5641fe1-e1a7-4f3f-b4d0-1dde55e47c83@nvidia.com>
Date: Tue, 18 Nov 2025 21:29:05 -0600
From: Dan Jurgens <danielj@...dia.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: netdev@...r.kernel.org, jasowang@...hat.com, pabeni@...hat.com,
 virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 jgg@...pe.ca, kevin.tian@...el.com, kuba@...nel.org, andrew+netdev@...n.ch,
 edumazet@...gle.com
Subject: Re: [PATCH net-next v11 04/12] virtio: Expose object create and
 destroy API

On 11/18/25 4:14 PM, Michael S. Tsirkin wrote:
> On Tue, Nov 18, 2025 at 08:38:54AM -0600, Daniel Jurgens wrote:

>> +int virtio_admin_obj_destroy(struct virtio_device *vdev,
>> +			     u16 obj_type,
>> +			     u32 obj_id,
>> +			     u16 group_type,
>> +			     u64 group_member_id)
> 
> what's the point of making it int when none of the callers
> check the return type?
> 

It's an API, and return codes are available. I don't have a use for them
in this series but perhaps a future user will.