netdev - Re: [PATCH net-next v1] devlink: Notify eswitch mode changes to devlink monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120065223.7c9d4462@kernel.org>
Date: Thu, 20 Nov 2025 06:52:23 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Parav Pandit <parav@...dia.com>, Jiri Pirko <jiri@...dia.com>,
 netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH net-next v1] devlink: Notify eswitch mode changes to
 devlink monitor

On Thu, 20 Nov 2025 13:09:35 +0100 Jiri Pirko wrote:
> Thu, Nov 20, 2025 at 02:56:28AM +0100, kuba@...nel.org wrote:
> >On Wed, 19 Nov 2025 18:59:36 +0200 Parav Pandit wrote:  
> >> When eswitch mode changes, notify such change to the
> >> devlink monitoring process.
> >> 
> >> After this notification, a devlink monitoring process
> >> can see following output:
> >> 
> >> $ devlink mon
> >> [eswitch,get] pci/0000:06:00.0: mode switchdev inline-mode none encap-mode basic
> >> [eswitch,get] pci/0000:06:00.0: mode legacy inline-mode none encap-mode basic
> >> 
> >> Reviewed-by: Jiri Pirko <jiri@...dia.com>  
> >
> >Jiri, did you have a chance to re-review this or the tag is stale?  
> 
> Nope, I reviewed internally, that's why the tag was taken.
> 
> >I have a slight preference for a new command ID here but if you
> >think GET is fine then so be it.  
> 
> Well, For the rest of the notifications, we have NEW/DEL commands.
> However in this case, as "eswitch" is somehow a subobject, there is no
> NEW/DEL value defined. I'm fine with using GET for notifications for it.
> I'm also okay with adding new ID, up to you.

Let's add a DEVLINK_CMD_ESWITCH_NTF. Having a separate ID makes it
easier / possible to use the same socket for requests and notifications.
-- 
pw-bot: cr