netdev - Re: [PATCH net-next v12 05/12] virtio_net: Query and set flow filter caps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <095dc6eb-a3c6-4809-b231-61875b52b376@nvidia.com>
Date: Thu, 20 Nov 2025 09:39:47 -0600
From: Dan Jurgens <danielj@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com,
 pabeni@...hat.com, virtualization@...ts.linux.dev, parav@...dia.com,
 shshitrit@...dia.com, yohadt@...dia.com, xuanzhuo@...ux.alibaba.com,
 eperezma@...hat.com, jgg@...pe.ca, kevin.tian@...el.com,
 andrew+netdev@...n.ch, edumazet@...gle.com
Subject: Re: [PATCH net-next v12 05/12] virtio_net: Query and set flow filter
 caps

On 11/19/25 7:51 PM, Jakub Kicinski wrote:
> On Wed, 19 Nov 2025 13:15:16 -0600 Daniel Jurgens wrote:
>> +/**
>> + * struct virtio_net_ff_cap_data - Flow filter resource capability limits
>> + * @groups_limit: maximum number of flow filter groups supported by the device
>> + * @classifiers_limit: maximum number of classifiers supported by the device
>> + * @rules_limit: maximum number of rules supported device-wide across all groups
>> + * @rules_per_group_limit: maximum number of rules allowed in a single group
>> + * @last_rule_priority: priority value associated with the lowest-priority rule
>> + * @selectors_per_classifier_limit: maximum selectors allowed in one classifier
>> + */
>> +struct virtio_net_ff_cap_data {
>> +	__le32 groups_limit;
>> +	__le32 classifiers_limit;
>> +	__le32 rules_limit;
>> +	__le32 rules_per_group_limit;
>> +	__u8 last_rule_priority;
>> +	__u8 selectors_per_classifier_limit;
> 
> pop in a :
> 
> 	/* private: */
> 
> comment here, otherwise kdoc will complain that @reserved is
> undocumented.
> 
>> +	__u8 reserved[2];
>> +};
> 
> That said, if you don't mind pls wait for Michael's review with 
> the repost. Unless someone else provides review comments first.

Thanks, I have it queued up for the next version.