netdev - Re: [PATCH v3 5/8] RDMA/bng_re: Add infrastructure for enabling Firmware channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120160244.GW18335@unreal>
Date: Thu, 20 Nov 2025 18:02:44 +0200
From: Leon Romanovsky <leonro@...dia.com>
To: Siva Reddy Kallam <siva.kallam@...adcom.com>
CC: <jgg@...dia.com>, <linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>,
	<vikas.gupta@...adcom.com>, <selvin.xavier@...adcom.com>,
	<anand.subramanian@...adcom.com>, <usman.ansari@...adcom.com>
Subject: Re: [PATCH v3 5/8] RDMA/bng_re: Add infrastructure for enabling
 Firmware channel

On Mon, Nov 17, 2025 at 05:11:23PM +0000, Siva Reddy Kallam wrote:
> Add infrastructure for enabling Firmware channel.
> 
> Signed-off-by: Siva Reddy Kallam <siva.kallam@...adcom.com>
> Reviewed-by: Usman Ansari <usman.ansari@...adcom.com>
> ---
>  drivers/infiniband/hw/bng_re/bng_dev.c | 120 +++++++-
>  drivers/infiniband/hw/bng_re/bng_fw.c  | 361 ++++++++++++++++++++++++-
>  drivers/infiniband/hw/bng_re/bng_fw.h  | 133 ++++++++-
>  drivers/infiniband/hw/bng_re/bng_re.h  |  45 +++
>  drivers/infiniband/hw/bng_re/bng_res.c |   2 +
>  drivers/infiniband/hw/bng_re/bng_res.h | 102 +++++++
>  drivers/infiniband/hw/bng_re/bng_tlv.h | 128 +++++++++
>  7 files changed, 885 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/infiniband/hw/bng_re/bng_tlv.h

<...>

> +int bng_re_rcfw_start_irq(struct bng_re_rcfw *rcfw, int msix_vector,
> +			  bool need_init)
> +{
> +	struct bng_re_creq_ctx *creq;
> +	struct bng_re_res *res;
> +	int rc;
> +
> +	creq = &rcfw->creq;
> +	res = rcfw->res;
> +
> +	if (creq->irq_handler_avail)
> +		return -EFAULT;
> +
> +	creq->msix_vec = msix_vector;
> +	if (need_init)
> +		tasklet_setup(&creq->creq_tasklet, bng_re_service_creq);
> +	else
> +		tasklet_enable(&creq->creq_tasklet);

I wonder if new drivers need to use workqueues instead.
https://lwn.net/Articles/966894/

Thanks