netdev - Re: [PATCH net-next v4 2/7] phy: add hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251120185126.6e536058@kmaincent-XPS-13-7390>
Date: Thu, 20 Nov 2025 18:51:26 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Russell King <linux@...linux.org.uk>,
 Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrei Botila
 <andrei.botila@....nxp.com>, Richard Cochran <richardcochran@...il.com>,
 Andrew Lunn <andrew@...n.ch>, Simon Horman <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Jacob Keller <jacob.e.keller@...el.com>,
 bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org, "Russell
 King (Oracle)" <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH net-next v4 2/7] phy: add hwtstamp_get callback to phy
 drivers

On Thu, 20 Nov 2025 17:45:35 +0000
Vadim Fedorenko <vadim.fedorenko@...ux.dev> wrote:

> PHY devices had lack of hwtstamp_get callback even though most of them
> are tracking configuration info. Introduce new call back to
> mii_timestamper.

It's a pity you didn't take my comment into account. :/

" It would be nice to update this kdoc note:
https://elixir.bootlin.com/linux/v6.18-rc6/source/net/core/dev_ioctl.c#L252 "

> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> ---
>  drivers/net/phy/phy.c           | 3 +++
>  include/linux/mii_timestamper.h | 5 +++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 350bc23c1fdb..13dd1691886d 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -478,6 +478,9 @@ int __phy_hwtstamp_get(struct phy_device *phydev,
>  	if (!phydev)
>  		return -ENODEV;
>  
> +	if (phydev->mii_ts && phydev->mii_ts->hwtstamp_get)
> +		return phydev->mii_ts->hwtstamp_get(phydev->mii_ts, config);
> +
>  	return -EOPNOTSUPP;
>  }
>  
> diff --git a/include/linux/mii_timestamper.h b/include/linux/mii_timestamper.h
> index 08863c0e9ea3..3102c425c8e0 100644
> --- a/include/linux/mii_timestamper.h
> +++ b/include/linux/mii_timestamper.h
> @@ -29,6 +29,8 @@ struct phy_device;
>   *
>   * @hwtstamp_set: Handles SIOCSHWTSTAMP ioctl for hardware time stamping.
>   *
> + * @hwtstamp_get: Handles SIOCGHWTSTAMP ioctl for hardware time stamping.
> + *
>   * @link_state: Allows the device to respond to changes in the link
>   *		state.  The caller invokes this function while holding
>   *		the phy_device mutex.
> @@ -55,6 +57,9 @@ struct mii_timestamper {
>  			     struct kernel_hwtstamp_config *kernel_config,
>  			     struct netlink_ext_ack *extack);
>  
> +	int  (*hwtstamp_get)(struct mii_timestamper *mii_ts,
> +			     struct kernel_hwtstamp_config *kernel_config);
> +
>  	void (*link_state)(struct mii_timestamper *mii_ts,
>  			   struct phy_device *phydev);
>  

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com