netdev - Re: [PATCH v21 01/23] cxl/mem: refactor memdev allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251120180805.00001699@huawei.com>
Date: Thu, 20 Nov 2025 18:08:05 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: <alejandro.lucero-palau@....com>
CC: <linux-cxl@...r.kernel.org>, <netdev@...r.kernel.org>,
	<dan.j.williams@...el.com>, <edward.cree@....com>, <davem@...emloft.net>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<dave.jiang@...el.com>, Alejandro Lucero <alucerop@....com>
Subject: Re: [PATCH v21 01/23] cxl/mem: refactor memdev allocation

On Wed, 19 Nov 2025 19:22:14 +0000
alejandro.lucero-palau@....com wrote:

> From: Alejandro Lucero <alucerop@....com>
> 
> In preparation for always-synchronous memdev attach, refactor memdev
> allocation and fix release bug in devm_cxl_add_memdev() when error after
> a successful allocation.
> 
> The diff is busy as this moves cxl_memdev_alloc() down below the definition
> of cxl_memdev_fops and introduces devm_cxl_memdev_add_or_reset() to
> preclude needing to export more symbols from the cxl_core.
> 
> Fixes: 1c3333a28d45 ("cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures")
> 

No line break here. Fixes is part of the tag block and some tools
get grumpy if that isn't contiguous.  That includes a bot that runs
on linux-next.

> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Alejandro Lucero <alucerop@....com>

This SOB chain is wrong.  What was Dan's role in this?  As first SOB with no
Co-developed tag he would normally also be the author (From above)

I'm out of time for today so will leave review for another time. Just flagging
that without these tag chains being correct Dave can't pick this up even
if everything else is good.