lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251119200304.7a0a7905@kernel.org>
Date: Wed, 19 Nov 2025 20:03:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Remy D. Farley" <one-d-wide@...tonmail.com>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v4 2/2] doc/netlink: Expand nftables specification

On Wed, 19 Nov 2025 18:16:00 +0000 Remy D. Farley wrote:
> Getting out some changes I've accumulated while making nftables work
> with Rust netlink-bindings. Hopefully, this will be useful upstream.

In the future it's better to keep things in smaller patches.
Easier to review.

The docs have to be in ReST-compatible format I see:

Documentation/netlink/specs/nftables.yaml:66: WARNING: Field list ends without a blank line; unexpected unindent.
Documentation/netlink/specs/nftables.yaml:261: WARNING: Bullet list ends without a blank line; unexpected unindent.
Documentation/netlink/specs/nftables.yaml:261: WARNING: Field list ends without a blank line; unexpected unindent.

`make htmldocs` to repro

> +    # Defined in include/linux/netfilter/nf_tables.h

Isn't this the main header for nf_tables?
If yes then no need to comment, should be the obvious place.
If no - can we use 
	
	header: linux/netfilter/nf_tables.h

?

Last but not least when you post v2 please CC folks from netfilter:

NETFILTER
M:	Pablo Neira Ayuso <pablo@...filter.org>
M:	Jozsef Kadlecsik <kadlec@...filter.org>
M:	Florian Westphal <fw@...len.de>
R:	Phil Sutter <phil@....cc>
L:	netfilter-devel@...r.kernel.org
L:	coreteam@...filter.org
S:	Maintained

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ