netdev - Re: [PATCH] net/sched: act_ife: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSBRVrb0ic5h9DEZ@horms.kernel.org>
Date: Fri, 21 Nov 2025 11:47:34 +0000
From: Simon Horman <horms@...nel.org>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: Chen Ni <nichen@...as.ac.cn>, xiyou.wangcong@...il.com,
	jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/sched: act_ife: convert comma to semicolon

On Wed, Nov 12, 2025 at 05:50:36AM -0500, Jamal Hadi Salim wrote:
> On Wed, Nov 12, 2025 at 2:28 AM Chen Ni <nichen@...as.ac.cn> wrote:
> >
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
> 
> IIRC, Simon brought this up in the review as well...

Yes, I might have.
But at any rate I agree with the analysis above.

> 
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> 
> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>

...