netdev - Re: [PATCH net-next] net: stmmac: move stmmac_mac_finish() after stmmac_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSB9Pfd0cAd4CQgL@shell.armlinux.org.uk>
Date: Fri, 21 Nov 2025 14:54:53 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-stm32@...md-mailman.stormreply.com,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: stmmac: move stmmac_mac_finish() after
 stmmac_mac_config()

On Fri, Nov 21, 2025 at 01:03:59PM +0100, Maxime Chevallier wrote:
> Hi Russell,
> 
> On 21/11/2025 10:52, Russell King (Oracle) wrote:
> > Keep the functions and initialisers in the same order that they exist
> > in phylink_mac_ops. This is the preferred order for phylink methods
> > as it arranges the configuration methods by called order.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > index 970c670fc302..d16e522c1e7d 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> > @@ -932,7 +932,8 @@ static int stmmac_mac_finish(struct phylink_config *config, unsigned int mode,
> >  	struct stmmac_priv *priv = netdev_priv(ndev);
> >  
> >  	if (priv->plat->mac_finish)
> > -		priv->plat->mac_finish(ndev, priv->plat->bsp_priv, mode, interface);
> > +		priv->plat->mac_finish(ndev, priv->plat->bsp_priv, mode,
> > +				       interface);
> 
> This is just a line wrap, I don't really see the connexion with the
> commit log :( Some missing hunks in the commit maybe ?

Oh, I thought I hadn't sent the patch, but I had... meanwhile I'd
updated my local copy to fix the line wrap, forgotten I'd done that,
rebased the patch and ended up with a patch with that description
but with only the reformatting. Bah. I'll move it out of patchwork.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!