netdev - Re: [PATCH net] r8169: fix RTL8127 hang on suspend/shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8c902b9-f40c-4966-bb31-560e100b3cc0@gmail.com>
Date: Fri, 21 Nov 2025 20:59:23 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 David Miller <davem@...emloft.net>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Fabio Baltieri <fabio.baltieri@...il.com>
Subject: Re: [PATCH net] r8169: fix RTL8127 hang on suspend/shutdown

On 11/21/2025 6:58 PM, Heiner Kallweit wrote:
> There have been reports that RTL8127 hangs on suspend and shutdown,
> partially disappearing from lspci until power-cycling.
> According to Realtek disabling PLL's when switching to D3 should be
> avoided on that chip version. Fix this by aligning disabling PLL's
> with the vendor drivers, what in addition results in PLL's not being
> disabled when switching to D3hot on other chip versions.
> 
> Fixes: f24f7b2f3af9 ("r8169: add support for RTL8127A")
> Tested-by: Fabio Baltieri <fabio.baltieri@...il.com>
> Cc: stable@...r.kernel.org
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index de304d1eb..97dbe8f89 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -1517,11 +1517,20 @@ static enum rtl_dash_type rtl_get_dash_type(struct rtl8169_private *tp)
>  
>  static void rtl_set_d3_pll_down(struct rtl8169_private *tp, bool enable)
>  {
> -	if (tp->mac_version >= RTL_GIGA_MAC_VER_25 &&
> -	    tp->mac_version != RTL_GIGA_MAC_VER_28 &&
> -	    tp->mac_version != RTL_GIGA_MAC_VER_31 &&
> -	    tp->mac_version != RTL_GIGA_MAC_VER_38)
> -		r8169_mod_reg8_cond(tp, PMCH, D3_NO_PLL_DOWN, !enable);
> +	switch (tp->mac_version) {
> +	case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_24:
> +	case RTL_GIGA_MAC_VER_28:
> +	case RTL_GIGA_MAC_VER_31:
> +	case RTL_GIGA_MAC_VER_38:
> +		break;
> +	case RTL_GIGA_MAC_VER_80:
> +		r8169_mod_reg8_cond(tp, PMCH, D3_NO_PLL_DOWN, true);
> +		break;
> +	default:
> +		r8169_mod_reg8_cond(tp, PMCH, D3HOT_NO_PLL_DOWN, true);
> +		r8169_mod_reg8_cond(tp, PMCH, D3COLD_NO_PLL_DOWN, !enable);
> +		break;
> +	}
>  }
>  
>  static void rtl_reset_packet_filter(struct rtl8169_private *tp)

Will resubmit due to a missing blamed author.

--
pw-bot: cr