netdev - Re: [PATCH iwl-net 2/3] idpf: Fix RSS LUT configuration on down interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62207dc3-3deb-43c1-a895-53fe01bf20bd@intel.com>
Date: Fri, 21 Nov 2025 14:36:46 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Joshi, Sreedevi" <sreedevi.joshi@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "Tantilov, Emil S" <emil.s.tantilov@...el.com>
Subject: Re: [PATCH iwl-net 2/3] idpf: Fix RSS LUT configuration on down
 interfaces



On 11/21/2025 1:53 PM, Joshi, Sreedevi wrote:

...

>>> @@ -393,7 +393,10 @@ static u32 idpf_get_rxfh_indir_size(struct net_device *netdev)
>>>     * @netdev: network interface device structure
>>>     * @rxfh: pointer to param struct (indir, key, hfunc)
>>>     *
>>> - * Reads the indirection table directly from the hardware. Always returns 0.
>>> + * RSS LUT and Key information are read from driver's cached
>>> + * copy. When rxhash is off, rss lut will be displayed as zeros.
>>> + *
>>> + * Returns 0 on success.
>>
>> Can you make this Return: to make kdoc happy?
> Will do.
> BTW, looks like there are other occurrences of this in that file.

Yea, much of this file was committed before that check was put in 
place/enforced so there are many occurrences of this in the file :( We 
don't want to introduce any new violations though.

Thanks,
Tony