netdev - Re: [PATCH net-next 0/5] selftests: hw-net: toeplitz: read config from the NIC directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.2fe8d4c058a2d@gmail.com>
Date: Fri, 21 Nov 2025 18:10:02 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 andrew+netdev@...n.ch, 
 horms@...nel.org, 
 willemb@...gle.com, 
 petrm@...dia.com, 
 dw@...idwei.uk, 
 shuah@...nel.org, 
 linux-kselftest@...r.kernel.org, 
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 0/5] selftests: hw-net: toeplitz: read config
 from the NIC directly

Jakub Kicinski wrote:
> First patch here tries to auto-disable building the iouring sample.
> Our CI will still run the iouring test(s), of course, but it looks
> like the liburing updates aren't very quick in distroes and having
> to hack around it when developing unrelated tests is a bit annoying.
> 
> Remaining 4 patches iron out running the Toeplitz hash test against
> real NICs. I tested mlx5, bnxt and fbnic, they all pass now.
> I switched to using YNL directly in the C code, can't see a reason
> to get the info in Python and pass it to C via argv. The old code
> likely did this because it predates YNL.
> 
> Jakub Kicinski (5):
>   selftests: hw-net: auto-disable building the iouring C code
>   selftests: hw-net: toeplitz: make sure NICs have pure Toeplitz
>     configured
>   selftests: hw-net: toeplitz: read the RSS key directly from C
>   selftests: hw-net: toeplitz: read indirection table from the device
>   selftests: hw-net: toeplitz: give the test up to 4 seconds
> 
>  .../testing/selftests/drivers/net/hw/Makefile | 23 ++++++-
>  .../selftests/drivers/net/hw/toeplitz.c       | 65 ++++++++++++++++++-
>  .../selftests/drivers/net/hw/toeplitz.py      | 28 ++++----
>  3 files changed, 98 insertions(+), 18 deletions(-)

For the series:

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks for improving the test! Especially addressing the missing
indirection table.