netdev - Re: [PATCH net-next 3/3] net: dsa: append ethtool counters of all hidden ports to conduit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ccde53b-7c9f-407a-8f30-34d8932a51f4@lunn.ch>
Date: Mon, 24 Nov 2025 00:55:28 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 3/3] net: dsa: append ethtool counters of all
 hidden ports to conduit

On Sat, Nov 22, 2025 at 01:23:11PM +0200, Vladimir Oltean wrote:
> Currently there is no way to see packet counters on cascade ports, and
> no clarity on how the API for that would look like.
> 
> Because it's something that is currently needed, just extend the hack
> where ethtool -S on the conduit interface dumps CPU port counters, and
> also use it to dump counters of cascade ports.
> 
> Note that the "pXX_" naming convention changes to "sXX_pYY", to
> distinguish between ports having the same index but belonging to
> different switches. This has a slight chance of causing regressions to
> existing tooling:
> 
> - grepping for "p04_counter_name" still works, but might return more
>   than one string now
> - grepping for "    p04_counter_name" no longer works
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew