netdev - Re: [RFC net-next 02/13] selftests: ovpn: add notification parsing and matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSR--l90hvP6Fkld@krikkit>
Date: Mon, 24 Nov 2025 16:51:22 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Antonio Quartulli <antonio@...nvpn.net>
Cc: netdev@...r.kernel.org, Ralf Lici <ralf@...delbit.com>,
	Jakub Kicinski <kuba@...nel.org>, linux-kselftest@...r.kernel.org,
	Shuah Khan <shuah@...nel.org>
Subject: Re: [RFC net-next 02/13] selftests: ovpn: add notification parsing
 and matching

2025-11-21, 01:20:33 +0100, Antonio Quartulli wrote:
> diff --git a/tools/testing/selftests/net/ovpn/common.sh b/tools/testing/selftests/net/ovpn/common.sh
> index 88869c675d03..b91cf17ab01f 100644
> --- a/tools/testing/selftests/net/ovpn/common.sh
> +++ b/tools/testing/selftests/net/ovpn/common.sh
[...]
> @@ -82,6 +99,23 @@ add_peer() {
>  	fi
>  }
>  
> +compare_ntfs() {
> +	if [ ${#tmp_jsons[@]} -gt 0 ]; then
> +		[ "$FLOAT" == 1 ] && suffix="-float"
> +		expexted="json/peer${1}${suffix}.json"

nit: expected?

> +		received="${tmp_jsons[$1]}"
> +
> +		kill -TERM ${listener_pids[$1]} || true
> +		wait ${listener_pids[$1]} || true
> +		printf "Checking notifications for peer ${1}... "
> +		diff <(jq -s "${JQ_FILTER}" ${expexted}) \
> +			<(jq -s "${JQ_FILTER}" ${received})
> +		echo "OK"

Should that OK be conditional on what diff returns?

-- 
Sabrina