netdev - Re: [PATCH net v5] xsk: avoid data corruption on cq descriptor number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b3e00fe-38c0-45a3-9d34-205472839454@suse.de>
Date: Mon, 24 Nov 2025 17:51:46 +0100
From: Fernando Fernandez Mancera <fmancera@...e.de>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Jason Xing <kerneljasonxing@...il.com>
Cc: netdev@...r.kernel.org, csmate@....hu, bpf@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, sdf@...ichev.me, hawk@...nel.org,
 daniel@...earbox.net, ast@...nel.org, john.fastabend@...il.com,
 magnus.karlsson@...el.com
Subject: Re: [PATCH net v5] xsk: avoid data corruption on cq descriptor number



On 11/24/25 5:31 PM, Maciej Fijalkowski wrote:
>[...]
>>>>>> nit: duplicate if statement
>>>>>>
>>>>>> IIUC, I'm afraid you have to repost this patch after 24 hour...
>>>>>>
>>>>>
>>>>> Thanks, yes this if statement isn't necessary. Thanks! I will repost
>>>>> after 24 hours.
> 
> Fernando, if you repost, maybe we could include a helper function for
> setting destructor arg?
> 
> static void xsk_skb_destructor_set_addr(struct sk_buff *skb, u64 addr)
> {
> 	skb_shinfo(skb)->destructor_arg = (void *)((uintptr_t)addr | 0x1UL);
> }
> 
> when reading code it was sort of missing for me when seeing
> xsk_skb_destructor_{is,get}_addr().
> 

Sure, I am sending a v6 just now removing the if statement Jason 
suggested and adding this helper function. Thank you Maciej and Jason 
for the feedback.