netdev - Re: [PATCH v2] virtio_net: enhance wake/stop tx queue statistics accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <323a8b07-6df3-4cc4-960a-994649fb03e3@redhat.com>
Date: Tue, 25 Nov 2025 12:03:54 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: liming.wu@...uarmicro.com, "Michael S . Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Eugenio Pérez <eperezma@...hat.com>
Cc: kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
 netdev@...r.kernel.org, angus.chen@...uarmicro.com
Subject: Re: [PATCH v2] virtio_net: enhance wake/stop tx queue statistics
 accounting

On 11/20/25 2:53 AM, liming.wu@...uarmicro.com wrote:
> @@ -3521,6 +3526,9 @@ static void virtnet_tx_pause(struct virtnet_info *vi, struct send_queue *sq)
>  
>  	/* Prevent the upper layer from trying to send packets. */
>  	netif_stop_subqueue(vi->dev, qindex);
> +	u64_stats_update_begin(&sq->stats.syncp);
> +	u64_stats_inc(&sq->stats.stop);
> +	u64_stats_update_end(&sq->stats.syncp);

Minor non blocking nit: possibly use an helper even for this increment.

@Michael, Jason, Xuan, Eugenio: looks good?

Thanks,

Paolo