netdev - Re: [PATCH iproute2-next] tc: cake: add cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jyzecnkf.fsf@toke.dk>
Date: Tue, 25 Nov 2025 13:18:56 +0100
From: Toke Høiland-Jørgensen <toke@...e.dk>
To: David Ahern <dsahern@...il.com>, Stephen Hemminger
 <stephen@...workplumber.org>
Cc: cake@...ts.bufferbloat.net, netdev@...r.kernel.org, Jonas Köppeler
 <j.koeppeler@...berlin.de>
Subject: Re: [PATCH iproute2-next] tc: cake: add cake_mq support

David Ahern <dsahern@...il.com> writes:

> On 11/24/25 8:03 AM, Toke Høiland-Jørgensen wrote:
>> diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
>> index 15d1a37ac6d8..fb07a8898225 100644
>> --- a/include/uapi/linux/pkt_sched.h
>> +++ b/include/uapi/linux/pkt_sched.h
>> @@ -1036,6 +1036,7 @@ enum {
>>  	TCA_CAKE_STATS_DROP_NEXT_US,
>>  	TCA_CAKE_STATS_P_DROP,
>>  	TCA_CAKE_STATS_BLUE_TIMER_US,
>> +	TCA_CAKE_STATS_ACTIVE_QUEUES,
>>  	__TCA_CAKE_STATS_MAX
>>  };
>>  #define TCA_CAKE_STATS_MAX (__TCA_CAKE_STATS_MAX - 1)
>
> uapi changes should be a separate patch that I can drop when applying.

OK, sure.

>> diff --git a/tc/q_cake.c b/tc/q_cake.c
>> index e2b8de55e5a2..1c143e766888 100644
>> --- a/tc/q_cake.c
>> +++ b/tc/q_cake.c
>> @@ -525,7 +525,6 @@ static int cake_print_opt(const struct qdisc_util *qu, FILE *f, struct rtattr *o
>>  	    RTA_PAYLOAD(tb[TCA_CAKE_FWMARK]) >= sizeof(__u32)) {
>>  		fwmark = rta_getattr_u32(tb[TCA_CAKE_FWMARK]);
>>  	}
>> -
>>  	if (wash)
>>  		print_string(PRINT_FP, NULL, "wash ", NULL);
>>  	else
>
> why remove the spacing? whitespace helps readability.

That was a mistake that crept in when editing the patch; will put it
back :)

-Toke